Skip to content

Rm note as already merged#82

Merged
csvance merged 3 commits into
JuliaIO:mainfrom
xgdgsc:patch-1
Dec 18, 2025
Merged

Rm note as already merged#82
csvance merged 3 commits into
JuliaIO:mainfrom
xgdgsc:patch-1

Conversation

@xgdgsc
Copy link
Copy Markdown
Contributor

@xgdgsc xgdgsc commented Dec 17, 2025

Rm note as already merged

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.39%. Comparing base (ad3fd46) to head (7d9e59e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   83.91%   83.39%   -0.53%     
==========================================
  Files           7        7              
  Lines         541      554      +13     
==========================================
+ Hits          454      462       +8     
- Misses         87       92       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance
Copy link
Copy Markdown
Collaborator

csvance commented Dec 17, 2025

Thanks for catching this!

I would keep the note but have it say something along the lines of "Code generation support has been up-streamed but a new version has not yet been released. In order to make code generation work, you need to add ProtoBuf.jl from git."

@csvance csvance self-requested a review December 18, 2025 02:00
@csvance csvance merged commit 1943d06 into JuliaIO:main Dec 18, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants